Merge pull request #7 from rock-control/derivative_mode

feat: make the PID controllers derivative mode configurable
rock-control · Jan 28, 2025 · 074e093 · 074e093
2 parents 02e8111 + de8d4e1
commit 074e093
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/motor_controllerTypes.hpp b/motor_controllerTypes.hpp
@@ -14,6 +14,9 @@ namespace motor_controller {
 
         /** Max allowed variation in input command in unit/s */
         float ramp = base::infinity<float>();
+
+        /** How the derivative is computed */
+        DerivativeMode derivative_mode = Output;
     };
 }
 

diff --git a/tasks/PIDTask.cpp b/tasks/PIDTask.cpp
@@ -54,6 +54,7 @@ bool PIDTask::startHook()
     for (size_t i = 0; i < mSettings.size(); ++i) {
         mPIDs[i].reset();
         mPIDs[i].setPIDSettings(mSettings[i].pid);
+        mPIDs[i].setDerivativeMode(mSettings[i].derivative_mode);
     }
     return true;
 }
@@ -68,6 +69,7 @@ bool PIDTask::setSettings(std::vector< ::motor_controller::ActuatorSettings > co
     mSettings = value;
     for (size_t i = 0; i < mSettings.size(); ++i) {
         mPIDs[i].setPIDSettings(mSettings[i].pid);
+        mPIDs[i].setDerivativeMode(mSettings[i].derivative_mode);
     }
     return motor_controller::PIDTaskBase::setSettings(value);
 }