Force _event_time to be a datetime type #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatou
force-pushed
the
fix_joins_schema
branch
2 times, most recently
from
5a0828c to
d40f65a
Compare
mpatou
force-pushed
the
force_event_time_type
branch
from
859f859 to
1f787dc
Compare
Summary It makes things so much easier in applications like superset because the column is properly used. Test plan Changed the type, created a new wheel and used it in superset Reviewers: haneeshr
mpatou
force-pushed
the
force_event_time_type
branch
from
1f787dc to
9bdd441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It makes things so much easier in applications like superset because the
column is properly used.
Test plan
Changed the type, created a new wheel and used it in superset
Reviewers: haneeshr