fix: don't allow "@" in gratitude comment (#2542)

* fix: don't allow "@" in gratitude comment * chore: use ready-made decorator for validation
rolling-scopes · Oct 29, 2024 · 4877de9 · 4877de9
1 parent 758a203
commit 4877de9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/client/src/pages/gratitude.tsx b/client/src/pages/gratitude.tsx
@@ -118,6 +118,15 @@ function GratitudePage() {
               whitespace: true,
               message: 'The comment must contain at least 20 characters',
             },
+            {
+              validator: (_, value) => {
+                if (value.includes('@')) {
+                  return Promise.reject();
+                }
+                return Promise.resolve();
+              },
+              message: 'The comment can\'t include "@" symbol',
+            },
           ]}
         >
           <Input.TextArea rows={8} />

diff --git a/nestjs/src/gratitudes/dto/create-gratitude.dto.ts b/nestjs/src/gratitudes/dto/create-gratitude.dto.ts
@@ -1,5 +1,5 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsArray, IsEnum, IsNotEmpty, IsNumber, IsString, MinLength } from 'class-validator';
+import { IsArray, IsEnum, IsNotEmpty, IsNumber, IsString, MinLength, NotContains } from 'class-validator';
 import { Badge } from './badge.dto';
 
 export class CreateGratitudeDto {
@@ -16,6 +16,9 @@ export class CreateGratitudeDto {
   @IsNotEmpty()
   @IsString()
   @MinLength(20)
+  @NotContains('@', {
+    message: 'The comment can not contain "@" symbol',
+  })
   @ApiProperty()
   comment: string;