Add windows build #158
Open
Add windows build #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
livanov93,
LukasMacha97,
mcbed,
Raivias,
saikishor and
VX792
Raivias
reviewed
Nov 30, 2024
Comment on lines
+21
to
+24
| # if: | | ||
| # (github.event_name == 'issue_comment' && contains(github.event.comment.body, '/check-windows')) || | ||
| # (github.event_name == 'pull_request' && contains(github.event.label.name, 'check-windows')) || | ||
| # (github.event_name == 'workflow_dispatch') |
There was a problem hiding this comment.
Am I correct in assuming the comments are relate to the next increment of rolling out this CI? I'm not sure I understand the future use of the issue_comment and pull_requests types.
There was a problem hiding this comment.
Ah sorry, I haven't added the reference to ros-controls/realtime_tools#204
I was just adding these comments to get reminded of this possibility in case the windows build do not work well, or take way more time then all the other jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremential, to debug windows CI builds in other repos