Skip to content

Cleanup removed msg fields #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Cleanup removed msg fields #346

merged 1 commit into from
Apr 24, 2025

Conversation

christophfroehlich
Copy link
Contributor

PID is broken now since ros-controls/control_msgs#178 (comment)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (b1f2619) to head (e1cec98).
Report is 2 commits behind head on ros2-master.

Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #346      +/-   ##
===============================================
- Coverage        77.41%   77.38%   -0.04%     
===============================================
  Files               29       29              
  Lines             1333     1331       -2     
  Branches            92       92              
===============================================
- Hits              1032     1030       -2     
  Misses             250      250              
  Partials            51       51              
Flag Coverage Δ
unittests 77.38% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
control_toolbox/src/pid_ros.cpp 73.88% <ø> (-0.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit d7afc03 into ros2-master Apr 24, 2025
12 checks passed
@christophfroehlich christophfroehlich deleted the fix/pid_msg branch April 24, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants