Add Demos for SDF (backport #427) #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Aarav Gupta <[email protected]> Signed-off-by: Aarav Gupta <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit d2b2f0d)
Merged
ahcorde
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds demos for SDF. Linked to #ros2_control/1763.
These demos should help in testing the PR.
A couple of things I want an opinion on:
sdfdirectory is that okay or should something else be done?To test the diff_drive demo for SDF:
ros2 launch gz_ros2_control_demos diff_drive_example_sdf.launch.pyros2 run gz_ros2_control_demos example_diff_driveThe simulation should show a behaviour similar to the diff_drive demo for URDF.
This is an automatic backport of pull request #427 done by Mergify.