Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] codecov updates #1147

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Oct 30, 2023

Similar to ros-controls/ros2_controllers#804

  • Update of the packages
  • Exclude test folders from stats
  • Add codecov badge to readme
  • Remove the invalid branches key from the workflow_displatch

Do we want to activate codecov also for humble?

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #1147 (7157d95) into master (971ff39) will increase coverage by 15.83%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1147       +/-   ##
===========================================
+ Coverage   31.62%   47.46%   +15.83%     
===========================================
  Files          94       41       -53     
  Lines       10838     3451     -7387     
  Branches     7419     1874     -5545     
===========================================
- Hits         3428     1638     -1790     
+ Misses        804      486      -318     
+ Partials     6606     1327     -5279     
Flag Coverage Δ
unittests 47.46% <ø> (+15.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 53 files with indirect coverage changes

@bmagyar bmagyar merged commit 5e6b676 into ros-controls:master Nov 3, 2023
17 of 18 checks passed
@christophfroehlich christophfroehlich deleted the ci/fix_codecov branch November 4, 2023 08:42
@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Feb 17, 2024
mergify bot pushed a commit that referenced this pull request Feb 17, 2024
* Fix coverage build and exclude test folders

* Add codecov badge

* Remove ignored package

---------

Co-authored-by: Bence Magyar <[email protected]>
(cherry picked from commit 5e6b676)

# Conflicts:
#	.github/workflows/ci-coverage-build.yml
bmagyar pushed a commit that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants