-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of M_PI on Windows #1036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
duringhof,
fmauch and
mcbed
February 11, 2024 18:08
bmagyar
approved these changes
Feb 11, 2024
Thank you! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1036 +/- ##
===========================================
+ Coverage 47.71% 72.41% +24.69%
===========================================
Files 41 41
Lines 3871 3639 -232
Branches 1833 1782 -51
===========================================
+ Hits 1847 2635 +788
+ Misses 751 691 -60
+ Partials 1273 313 -960
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Feb 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2024
(cherry picked from commit 9ab848a)
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2024
(cherry picked from commit 9ab848a)
This was referenced Feb 11, 2024
bmagyar
pushed a commit
that referenced
this pull request
Feb 12, 2024
bmagyar
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M_PI
andM_PI_2
are not part of the C or C++ standard. However, they are available in almost all major compilers. On Windows, to make sure that they are defined,_USE_MATH_DEFINES
needs to be defined when#include <cmath>
or#include <math.h>
is included. This PR make sure that_USE_MATH_DEFINES
is defined wheneverM_PI
orM_PI_2
is used, for Windows compatibility.Checklist:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)