-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Eigen CMake target #1058
Use Eigen CMake target #1058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
===========================================
+ Coverage 47.71% 72.16% +24.44%
===========================================
Files 41 41
Lines 3871 3639 -232
Branches 1833 1781 -52
===========================================
+ Hits 1847 2626 +779
+ Misses 751 700 -51
+ Partials 1273 313 -960
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for using modern CMake :-)
(cherry picked from commit 7d38fb9)
(cherry picked from commit 7d38fb9)
I changed the CMake file to use Eigen's CMake target as described here https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html
See ros-controls/control_toolbox#178 for the issues with RHEL 8.