Improved tf_prefix based on namespace #1060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f_prefix when not there yet
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
erickisos,
livanov93 and
saikishor
saikishor
reviewed
Feb 26, 2024
saikishor
approved these changes
Feb 27, 2024
Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich
requested changes
Apr 13, 2024
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1048.
When using robot namespace as
tf_prefix, it now removes any starting '/' and only adds an ending '/' if not present already.Starting with '/' is not common in TF2 and showed compatibility issues with for instance
robot_localization.