Add parameter check for geometric values #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-humble
github-actions
bot
requested review from
arne48,
bmagyar,
destogl,
mcbed,
olivier-stasse,
peterdavidfagan and
progtologist
christophfroehlich
added
the
backport-iron
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 7170328) # Conflicts: # diff_drive_controller/test/test_diff_drive_controller.cpp # tricycle_controller/src/tricycle_controller_parameter.yaml # tricycle_controller/test/test_tricycle_controller.cpp
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 7170328)
This was referenced May 9, 2024
bmagyar
pushed a commit
that referenced
this pull request
May 9, 2024
christophfroehlich
added a commit
that referenced
this pull request
May 9, 2024
bmagyar
pushed a commit
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this post at RSE, I thought it could be a good idea to add simple checks to geometric values of the controllers for mobile robots. For example,
wheel_radiuswheel_baseand others must not be zero ➡️ I added agt<>: [0.0]validator for them. This also should help if a user misspelled or forgot these parameters.