Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add now missing includes #1226

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Add now missing includes #1226

merged 1 commit into from
Jul 21, 2024

Conversation

christophfroehlich
Copy link
Contributor

ros-controls/ros2_control#1627 removed lots of unused dependencies in the upstream packages, but now lots of packages here fail because of missing includes.

IMHO this was bad practice, so I'll fix them here instead of reverting the upstream changes.

👀 @henrygerardmoore

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (990bfb6) to head (00eb3b8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.02%     
==========================================
  Files          95       95              
  Lines        8585     8586       +1     
  Branches      719      719              
==========================================
  Hits         7432     7432              
  Misses        883      883              
- Partials      270      271       +1     
Flag Coverage Δ
unittests 86.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 86.59% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <ø> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 93.60% <ø> (ø)
...ster/test/test_force_torque_sensor_broadcaster.cpp 97.24% <ø> (ø)
...r_broadcaster/test/test_imu_sensor_broadcaster.cpp 95.71% <ø> (ø)
..._broadcaster/test/test_joint_state_broadcaster.cpp 93.85% <ø> (ø)
pid_controller/test/test_pid_controller.hpp 84.61% <ø> (ø)
...broadcaster/test/test_range_sensor_broadcaster.cpp 94.73% <ø> (ø)
...library/test/test_steering_controllers_library.hpp 96.87% <ø> (ø)
...cycle_controller/test/test_tricycle_controller.cpp 89.32% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

We have to recheck if the downstream packages are building or not with the changes from ros-controls/ros2_control#1627, if not we have to propagate the changes to downstream packages to avoid issues with the releases in ROS Buildfarm.

FYI @henrygerardmoore

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a surprisingly small amount to what I expected from the OP ;) thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants