Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers and add url tags (backport #1363) #1365

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 12, 2024

The contents of the package.xml get parsed for index.ros.org, so I thought it might be worth updating them.

  • Update the current maintainers
  • Where possible, I added the original authors as <author>
  • add url tags, but only to github and control.ros.org homepage. The direct links to the controllers have the ROS distro in the URL, that would soon become outdated.
    This is an automatic backport of pull request Update maintainers and add url tags #1363 done by Mergify.

(cherry picked from commit de77fd0)

# Conflicts:
#	diff_drive_controller/package.xml
#	parallel_gripper_controller/package.xml
#	pose_broadcaster/package.xml
#	range_sensor_broadcaster/package.xml
#	ros2_controllers/package.xml
Copy link
Contributor Author

mergify bot commented Nov 12, 2024

Cherry-pick of de77fd0 has failed:

On branch mergify/bp/iron/pr-1363
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit de77fd0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ackermann_steering_controller/package.xml
	modified:   admittance_controller/package.xml
	modified:   bicycle_steering_controller/package.xml
	modified:   effort_controllers/package.xml
	modified:   force_torque_sensor_broadcaster/package.xml
	modified:   forward_command_controller/package.xml
	modified:   gripper_controllers/package.xml
	modified:   imu_sensor_broadcaster/package.xml
	modified:   joint_state_broadcaster/package.xml
	modified:   joint_trajectory_controller/package.xml
	modified:   pid_controller/package.xml
	modified:   position_controllers/package.xml
	modified:   ros2_controllers_test_nodes/package.xml
	modified:   rqt_joint_trajectory_controller/package.xml
	modified:   steering_controllers_library/package.xml
	modified:   tricycle_controller/package.xml
	modified:   tricycle_steering_controller/package.xml
	modified:   velocity_controllers/package.xml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   diff_drive_controller/package.xml
	deleted by us:   parallel_gripper_controller/package.xml
	both modified:   pose_broadcaster/package.xml
	both modified:   range_sensor_broadcaster/package.xml
	both modified:   ros2_controllers/package.xml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (af1a840) to head (d3da765).
Report is 2 commits behind head on iron.

Additional details and impacted files
@@           Coverage Diff           @@
##             iron    #1365   +/-   ##
=======================================
  Coverage   64.92%   64.93%           
=======================================
  Files         107      107           
  Lines       12283    12283           
  Branches     7577     7577           
=======================================
+ Hits         7975     7976    +1     
  Misses       1540     1540           
+ Partials     2768     2767    -1     
Flag Coverage Δ
unittests 64.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@christophfroehlich christophfroehlich merged commit debea17 into iron Nov 13, 2024
10 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1363 branch November 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants