Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TractionLimiter: Fix wrong input checks (backport #1341) #1366

Merged
merged 1 commit into from
Nov 13, 2024

TractionLimiter: Fix wrong input checks (#1341)

3cc7e2a
Select commit
Loading
Failed to load commit list.
Merged

TractionLimiter: Fix wrong input checks (backport #1341) #1366

TractionLimiter: Fix wrong input checks (#1341)
3cc7e2a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

65.29% (+0.25%) compared to 2ddb060

View this Pull Request on Codecov

65.29% (+0.25%) compared to 2ddb060

Details

Codecov Report

Attention: Patch coverage is 57.29730% with 79 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (2ddb060) to head (3cc7e2a).

Files with missing lines Patch % Lines
tricycle_controller/test/test_traction_limiter.cpp 54.33% 0 Missing and 79 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1366      +/-   ##
==========================================
+ Coverage   65.03%   65.29%   +0.25%     
==========================================
  Files         107      108       +1     
  Lines       12381    12562     +181     
  Branches     7670     7805     +135     
==========================================
+ Hits         8052     8202     +150     
+ Misses       1555     1522      -33     
- Partials     2774     2838      +64     
Files with missing lines Coverage Δ
tricycle_controller/src/traction_limiter.cpp 95.77% <100.00%> (+73.55%) ⬆️
tricycle_controller/test/test_traction_limiter.cpp 54.33% <54.33%> (ø)

... and 1 file with indirect coverage changes