Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused variable EPS in mecanum_drive_controller #1444

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shankar-Balajee
Copy link

@Shankar-Balajee Shankar-Balajee commented Dec 24, 2024

closes: #1441

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@Shankar-Balajee Shankar-Balajee changed the title Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD Dec 24, 2024
@Shankar-Balajee Shankar-Balajee changed the title Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD Dec 24, 2024
@Shankar-Balajee Shankar-Balajee changed the title closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD Closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD Dec 24, 2024
@Shankar-Balajee Shankar-Balajee changed the title Closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp KEYWORD Closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp Dec 24, 2024
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thank you!

No reason in my opinion to keep it commented, just delete it.

@saikishor saikishor changed the title Closes #1441 : Cleaned up unused variable EPS in /mecanum_drive_controller/test_mecanum_drive_controller.cpp Clean up unused variable EPS in mecanum_drive_controller Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup an unused variable
4 participants