Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Update requirements of state interfaces #798

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[JTC] Update requirements of state interfaces #798

merged 1 commit into from
Oct 16, 2023

Conversation

christophfroehlich
Copy link
Contributor

A small adaption of the docs explaining requirements of command and state interfaces.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #798 (b37cfd6) into master (f62fc3a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   30.88%   30.88%           
=======================================
  Files           7        7           
  Lines         832      832           
  Branches      505      505           
=======================================
  Hits          257      257           
  Misses        133      133           
  Partials      442      442
Flag Coverage Δ
unittests 30.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bmagyar
bmagyar approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@bmagyar bmagyar merged commit c831b6c into ros-controls:master Oct 16, 2023
15 checks passed
mergify bot pushed a commit that referenced this pull request Oct 16, 2023
@christophfroehlich @mergify
Update requirements of state interfaces (#798)
c0eb3d7 
(cherry picked from commit c831b6c)

# Conflicts:
#	joint_trajectory_controller/doc/userdoc.rst
@mergify mergify bot mentioned this pull request Oct 16, 2023
Closed
@christophfroehlich christophfroehlich deleted the jtc/fix_doc_interfaces branch October 21, 2023 09:04
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 15, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
226a8c3
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 17, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
5841e9a
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 19, 2023
@christophfroehlich
Merge branch 'master' into jtc/controller_plugin
3e78665 
Squashed commit of the following:

commit 0a9f4b0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 16 23:17:20 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.4 to 0.3.5 (ros-controls#833)

commit 3fc0f50
Author: Christoph Fröhlich <[email protected]>
Date:   Wed Nov 15 20:03:40 2023 +0100

    [JTC] Activate update of dynamic parameters (ros-controls#761)

commit b13ae5b
Author: Christoph Fröhlich <[email protected]>
Date:   Wed Nov 15 19:14:09 2023 +0100

    [JTC] Fix tests when state offset is used (ros-controls#797)

    * Simplify initialization of states
    * Rename read_state_from_hardware method
    * Don't set state_desired in on_activate
    ---------

    Co-authored-by: Dr. Denis <[email protected]>

commit f1a5397
Author: Christoph Fröhlich <[email protected]>
Date:   Wed Nov 15 12:18:38 2023 +0100

    [JTC] Remove deprecation warnings, set `allow_nonzero_velocity_at_trajectory_end` default false (ros-controls#834)

commit 232154d
Author: Christoph Fröhlich <[email protected]>
Date:   Sat Nov 11 15:30:19 2023 +0100

    [CI] Update coverage workflows and some cleanup (ros-controls#819)

    * Add CI coverage jobs for humble and iron

    * Add all packages to source build

    * Update repos files

    * Build ros-control packages from source

    * use humble job names

    Co-authored-by: Christoph Fröhlich <[email protected]>

    ---------

    Co-authored-by: Bence Magyar <[email protected]>

commit 0196eeb
Author: Tony Baltovski <[email protected]>
Date:   Thu Nov 9 17:15:45 2023 -0500

    [diff_drive_controller] Fixed typos in diff_drive_controller_parameter.yaml. (ros-controls#822)

commit 71ec842
Author: Christoph Fröhlich <[email protected]>
Date:   Tue Nov 7 13:47:23 2023 +0100

    [CI] Re-add humble workflow files and add iron to readme (ros-controls#818)

commit 9d4ea6b
Author: Bence Magyar <[email protected]>
Date:   Tue Nov 7 12:01:23 2023 +0000

    [diff_drive_controller] Remove non-stamped Twist option (ros-controls#812)

commit 5f78fe4
Author: Bence Magyar <[email protected]>
Date:   Tue Nov 7 12:01:02 2023 +0000

    Adjust tests after passing URDF to controllers (ros-controls#817)

commit 2c6d7a6
Author: Bence Magyar <[email protected]>
Date:   Mon Nov 6 18:29:10 2023 +0000

    Add iron branch (ros-controls#814)

commit f81a82c
Author: Christoph Fröhlich <[email protected]>
Date:   Fri Nov 3 21:18:31 2023 +0100

    [CI] Codecov  (ros-controls#807)

commit c6ecab7
Author: Bence Magyar <[email protected]>
Date:   Wed Nov 1 21:38:16 2023 +0000

    Use pre-commit fork of clang-format instead of local (ros-controls#813)

commit 6e46053
Author: Bence Magyar <[email protected]>
Date:   Tue Oct 31 21:34:10 2023 +0000

    3.17.0

commit 822552f
Author: Bence Magyar <[email protected]>
Date:   Tue Oct 31 21:33:40 2023 +0000

    Update changelogs

commit 8a90b51
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 31 20:27:04 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#810)

commit b65314d
Author: Christoph Fröhlich <[email protected]>
Date:   Thu Oct 26 12:09:27 2023 +0200

    Cleanup comments and unnecessary checks (ros-controls#803)

commit b36b9d2
Author: Christoph Fröhlich <[email protected]>
Date:   Tue Oct 24 20:17:28 2023 +0200

    [CI] Fix coverage build and codecov stats (ros-controls#804)

commit 22356e0
Author: Dr. Denis <[email protected]>
Date:   Mon Oct 16 18:49:47 2023 +0200

    [TestNodes] Optimize output about setup of JTC publisher (ros-controls#792)

commit ac291ab
Author: Christoph Fröhlich <[email protected]>
Date:   Mon Oct 16 13:00:53 2023 +0200

    Steering controllers library: fix open loop mode (ros-controls#793)

    * set last*velocity variables for open loop odometry

    * Make function arguments const

    * Update function in header file too

commit c831b6c
Author: Christoph Fröhlich <[email protected]>
Date:   Mon Oct 16 12:58:44 2023 +0200

    Update requirements of state interfaces (ros-controls#798)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
63d1b81
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
ce9b37b
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
8324772
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
@christophfroehlich
Update requirements of state interfaces (backport ros-controls#798)
1932f6e
bmagyar pushed a commit that referenced this pull request Dec 6, 2023
@christophfroehlich @bmagyar
Update requirements of state interfaces (backport #798)
3a23fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@livanov93 livanov93 Awaiting requested review from livanov93

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@progtologist progtologist Awaiting requested review from progtologist

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar