Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble backport diff_drive tf_prefix | change tf separation from / to _ #832

Closed
wants to merge 4 commits into from

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Nov 13, 2023

Backporting a feature with tf parameters for diff_drive and changing the separator from / to _.

bobbleballs and others added 3 commits November 13, 2023 14:47
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
@christophfroehlich
Copy link
Contributor

This is a duplicate of #726, which got stuck because of a merge conflict. @bmagyar could you have a look there please?

@delihus
Copy link
Contributor Author

delihus commented Nov 13, 2023

This is a duplicate of #726, which got stuck because of a merge conflict. @bmagyar could you have a look there please?

Ehhh... yeah...
I didn't notice. Overall what about changing the / with the _. It is not common to use the / in tfs.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (humble@6d75314). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d82e60b differs from pull request most recent head 583da3f. Consider uploading reports for the commit 583da3f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             humble     #832   +/-   ##
=========================================
  Coverage          ?   35.51%           
=========================================
  Files             ?       86           
  Lines             ?     9246           
  Branches          ?     5741           
=========================================
  Hits              ?     3284           
  Misses            ?      966           
  Partials          ?     4996           
Flag Coverage Δ
unittests 35.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@delihus delihus closed this Nov 14, 2023
@delihus delihus deleted the humble branch January 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants