[JTC] Convert lambda to class functions #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl,
jaron-l,
moriarty and
progtologist
8 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #945 +/- ##
=======================================
Coverage 47.22% 47.22%
=======================================
Files 41 41
Lines 3871 3871
Branches 1827 1827
=======================================
Hits 1828 1828
Misses 775 775
Partials 1268 1268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
force-pushed
the
jtc/cleanup
branch
from
f7a7eae
to
6f67f65
Compare
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
bmagyar
reviewed
Jan 4, 2024
joint_trajectory_controller/test/test_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
saikishor
reviewed
Jan 4, 2024
joint_trajectory_controller/test/test_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
saikishor
approved these changes
Jan 4, 2024
bmagyar
approved these changes
Jan 22, 2024
christophfroehlich
merged commit 833ed7f
into
ros-controls:master
12 of 14 checks passed
|
Probably helps avoiding conflicts with other backports. |
bmagyar
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Convert lambdas to member functions * Make member function const * Add a test for compute_error function * Make reference_wrapper argument const * Iterate over error fields (cherry picked from commit 833ed7f) # Conflicts: # joint_trajectory_controller/include/joint_trajectory_controller/tolerances.hpp # joint_trajectory_controller/src/joint_trajectory_controller.cpp
mergify bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Convert lambdas to member functions * Make member function const * Add a test for compute_error function * Make reference_wrapper argument const * Iterate over error fields (cherry picked from commit 833ed7f) # Conflicts: # joint_trajectory_controller/include/joint_trajectory_controller/tolerances.hpp
bmagyar
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some items of #944:
and minor changes
assign_interface_from_pointconstcheck_state_tolerance_per_jointsort_to_local_joint_orderas const member functionThis is breaking ABI, I guess we should not backport this? Then I'd make a manual backport of the "fix format warning"