Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacenav: Changed name of executable in launch files to match installed node #230

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

chriseichmann
Copy link
Contributor

@chriseichmann chriseichmann commented Feb 15, 2022

The installed executable was named spacenav_node in CMakeLists.txt:50, but the launch files tried to call executable='spacenav'.

I've fixed the spelling in the three launch files and tested them on foxy.

@chriseichmann chriseichmann changed the title Changed name of executable in launch files to match installed node Spacenav: Changed name of executable in launch files to match installed node Feb 15, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the very long delay here. This is absolutely correct; thanks for the fix! Note that I am going to merge this onto the ros2 branch, since that is the current one we are using.

@clalancette clalancette changed the base branch from foxy-devel to ros2 September 14, 2023 15:21
@clalancette clalancette force-pushed the ros2-launch-executables branch from cf33e21 to 24042ac Compare September 14, 2023 15:26
@clalancette clalancette merged commit f06aece into ros-drivers:ros2 Sep 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants