-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planning Constraints from MoveIt Request #62
Open
Jmeyer1292
wants to merge
5
commits into
ros-industrial-attic:indigo-devel
Choose a base branch
from
Jmeyer1292:feature/planner_constraints_from_moveit
base: indigo-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1e12b31
Added a new loadConstraints function that returns a vector of Constra…
dbfe618
Fixup
65964d8
Initially working impl of loading a combination of default constraint…
4af0385
fixup
9076d7f
Added a check to handle the case where no pose constraints are placed…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,6 +125,7 @@ namespace constrained_ik | |
/** @brief Reset the planners IK solver configuration to it default settings */ | ||
void resetSolverConfiguration(); | ||
|
||
|
||
private: | ||
/** | ||
* @brief Preform position and orientation interpolation between start and stop. | ||
|
@@ -137,6 +138,15 @@ namespace constrained_ik | |
std::vector<Eigen::Affine3d,Eigen::aligned_allocator<Eigen::Affine3d> > | ||
interpolateCartesian(const Eigen::Affine3d& start, const Eigen::Affine3d& stop, double ds, double dt) const; | ||
|
||
// Constraint additions | ||
std::vector<std::pair<bool, Constraint*> > resolveConstraints() const; | ||
|
||
Constraint* createConstraint(const moveit_msgs::PositionConstraint& pos_constraint) const; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it not be safer (memory-wise) to return smart pointers? |
||
|
||
Constraint* createConstraint(const moveit_msgs::OrientationConstraint& orient_constraint) const; | ||
|
||
std::vector<std::pair<bool, Constraint*> > default_constraints_; /**< These parameters are loaded from YAML files and may be overridden by | ||
constraints specified through planning requests. */ | ||
double translational_discretization_step_; /**< Max translational discretization step */ | ||
double orientational_discretization_step_; /**< Max orientational discretization step */ | ||
bool debug_mode_; /**< Debug state */ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to drop the virtual and use override instead.