Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indigo] Use ceres binary #109

Merged
merged 3 commits into from
Sep 22, 2017

Conversation

130s
Copy link
Member

@130s 130s commented Aug 20, 2017

This PR makes industrial_calibration binary release ready.

Address #32.
And even more, with this PR merged in, this package will become ready for binary release IMO.

  • As noted there, binary of libceres-dev has been available for 2 years already. Add some more missing dependency

  • On my forked repo,

    -- Found Ceres version 1.8.0: /usr/include;/usr/include/eigen3;/usr/include
    

@gavanderhoorn
Copy link
Member

I know SwRI is working on an extensive rewrite of the packages. Does this release include those changes?

If not, would it make sense to wait for those changes, as last I heard to fixed quite a few outstanding issues with the code.

@130s
Copy link
Member Author

130s commented Aug 21, 2017

I know SwRI is working on an extensive rewrite of the packages. Does this release include those changes?

I'm just not aware of any current activities about this package and no, there's no changes from SwRI's recent work included in this PR.

If not, would it make sense to wait for those changes, as last I heard to fixed quite a few outstanding issues with the code.

I have no opinion whether we should wait or not. I'm only suggesting dependency improvement and CI optimization (and as a result the packages will become release-able).

@130s
Copy link
Member Author

130s commented Sep 20, 2017

Having found (from almost 2 years ago discussion #62 (comment) and since then I can't find an answer to that) that whether ceres 1.8 is new enough for this package or not is not yet clarified.

Knowing that, I split the commit 7581f15 into 2 so that the one that uses binary version of ceres can be easily reverted if necessary.

@AustinDeric
Copy link
Contributor

I think we should go ahead and merge this in and don't wait on the re-write of the code. The code re-write can be found here:

https://github.com/geoffreychiou/IC2

We are about to start field tests using the GUI.

@130s 130s changed the title [indigo] Make industrial_calibration binary release ready [indigo] Use ceres binary Sep 21, 2017
@130s
Copy link
Member Author

130s commented Sep 21, 2017

I just opened #112, which should be more straight forward to review I think.

That is with exactly the same set of commits except the last one that installs the binary version of ceres. As repeatedly noted, there hasn't been confirmation if version 1.8.0 is new enough for this package. There's also a comment on discourse that indicates incompatibility between 1.8 and later versions. @AustinDeric I'd appreciate if you can share how the binary version works.

Copy link
Member

@drchrislewis drchrislewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm crossing my fingers, but I don't see any obvious issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants