-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch UR10, UR10e and UR16e to effort controllers #525
Switch UR10, UR10e and UR16e to effort controllers #525
Conversation
As this PR is branching of Eventually, this should be changed for all 7 robot variants, though. |
I think, this can be implemented independently from #504 but for fine tuning it might be interesting whether it makes a difference whether we use the cylinder approximation for the inertia or we use the matrices provided by the robot controller. So, testing and fine-tuning this might require a rebase on #504. However, as the results from those tests will also impact #504, we should not wait for that to be merged, but develop them in parallel. I think, this won't be too much of an issue as there are no conflicts between those two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2bade90
to
6a64eb0
Compare
This fix addresses #521 which in turn addresses #386, and was worked on during WRID2020
Based on a rough understanding of this comment, only the three URs mentioned in the title have been updated.
PID values for the effort controllers were taken from here
After making these changes, the gazebo simulation of the robot was observed to start in a "weird" pose :
UR16e:
UR10 and UR10e:
However, the controllers initially seem to initially work well, and the robots could be jogged using the RQT Joint trajectory controller plugin