Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support lifecycle node #304

Open
wants to merge 16 commits into
base: rolling
Choose a base branch
from
Open

Support lifecycle node #304

wants to merge 16 commits into from

Commits on Apr 6, 2024

  1. Use SharedPtr and update base class in preparation for lifecycle node

    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c496ccc View commit details
    Browse the repository at this point in the history

  2. Extend lifecycle node to publisher, subscriber

    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    b0dfb86 View commit details
    Browse the repository at this point in the history

  3. Extend lifecycle node to camera publisher, camera subscriber, image t… 

    …ransport free function, subscriber filter, transport hints
    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6707860 View commit details
    Browse the repository at this point in the history

  4. Fix initialising and unit test

    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    ba5e599 View commit details
    Browse the repository at this point in the history

  5. Fix formatting and linting error

    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    8eae072 View commit details
    Browse the repository at this point in the history

  6. Add test for lifecycle node

    @Benjamin-Tan
    Benjamin-Tan committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    a570653 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Change the implementation to template class NodeType with backward co… 

    …mpatibility, according to the PR review.
    @Benjamin-Tan
    Benjamin-Tan committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    688e5de View commit details
    Browse the repository at this point in the history

  2. Fix formatting, linting error

    @Benjamin-Tan
    Benjamin-Tan committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    d58fdf8 View commit details
    Browse the repository at this point in the history

  3. Use raw pointer instead of unique ptr to workaround segfault, similar… 

    … to the initial implementation
    @Benjamin-Tan
    Benjamin-Tan committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    9bf1b8f View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Fix undefined reference when using clang

    @Benjamin-Tan
    Benjamin-Tan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    13fb135 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Update copyright to 2024

    @Benjamin-Tan
    Benjamin-Tan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    07b7bc7 View commit details
    Browse the repository at this point in the history

  2. Include headers from PR comments

    @Benjamin-Tan
    Benjamin-Tan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4c6d460 View commit details
    Browse the repository at this point in the history

  3. Include headers from PR comments <2>

    @Benjamin-Tan
    Benjamin-Tan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    c00ac8b View commit details
    Browse the repository at this point in the history

  4. Improve implementation to use shared ptr directly

    @Benjamin-Tan
    Benjamin-Tan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    9cf7398 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/rolling' into rolling

    @Benjamin-Tan
    Benjamin-Tan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    745b12f View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge remote-tracking branch 'upstream/rolling' into rolling

    @Benjamin-Tan
    Benjamin-Tan committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    84caa21 View commit details
    Browse the repository at this point in the history