-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create node executables using rclcpp_component macros #198
Create node executables using rclcpp_component macros #198
Conversation
I like using the macros, but I think there's still a good reason to put them in separate |
Sure, If you feel so, you can close this PR. The macros just seem "cleaner" to me but it's just my opinion. If you want to stick to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read up on rclcpp_components_register_node and now this PR makes sense to me. Once you add the suggested comment, I'll merge this.
|
||
set(FILTER_CHAINS | ||
scan_to_cloud_filter_chain | ||
scan_to_scan_filter_chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment describing what rclcpp_components_register_node does here? It's a very cool and useful macro, but the documentation isn't super easy to find, and it'd be nice to have a summary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment that briefly describes the macro
Looks good, merging! btw i find it very odd that rclcpp_components_register_node creates the templated node executable, but rclcpp_components_register_nodes (plural) doesn't..... |
rclcpp_components_register_node
macro can create templated source for node executable that runs the Node component.This PR replaces some boilerplate code using this macro.