Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake/python.cmake: Remove SETUPTOOLS_ARG_EXTRA for debian systems. #1129

Open
wants to merge 2 commits into
base: noetic-devel
Choose a base branch
from
Open

cmake/python.cmake: Remove SETUPTOOLS_ARG_EXTRA for debian systems. #1129

wants to merge 2 commits into from

Conversation

edowson
Copy link

@edowson edowson commented Dec 28, 2020

Remove SETUPTOOLS_ARG_EXTRA since "--install-layout=deb" is not supported
on Ubuntu-18.04. Using this argument causes make install to fail.

Signed-off-by: Elvis Dowson [email protected]

@edowson
cmake/python.cmake: Remove SETUPTOOLS_ARG_EXTRA for debian systems.
f0b6b9a 
Remove SETUPTOOLS_ARG_EXTRA since "--install-layout=deb" is not supported
on Ubuntu-18.04. Using this argument causes `make install` to fail.

Signed-off-by: Elvis Dowson <[email protected]>
@jspricke
Copy link
Member

This is wrong:

$ lsb_release -d
Description:    Ubuntu 18.04.4 LTS
$ python -c "from setuptools import setup; setup()" install -h | grep -B1 deb,
  --install-layout                     installation layout to choose (known
                                       values: deb, unix)

(same for Python 3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edowson @jspricke