Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate <depend> conditions in CMake variables #1134

Open
wants to merge 2 commits into
base: noetic-devel
Choose a base branch
from

Conversation

matthew-reynolds
Copy link
Contributor

Adds support for the condition attribute for <*depend> tags in package.xml format 3 (REP014)

#1038 added support for the condition attribute to the <build_type> tag, but it was never added to the other <*depend> tags.

Without this change:

In Noetic (py3), package.xml containing

  <exec_depend condition="$ROS_PYTHON_VERSION == 2">python-whatever</exec_depend>
  <exec_depend condition="$ROS_PYTHON_VERSION == 3">python3-whatever</exec_depend>

yields CMake variable: ${PROJECT_NAME}_EXEC_DEPENDS = "python-whatever;python3-whatever"

After this change:

The same package.xml yields CMake variable: ${PROJECT_NAME}_EXEC_DEPENDS = "python3-whatever"


If approved, I would also like this to be considered for backport to kinetic & melodic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant