Evaluate <depend> conditions in CMake variables #1134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
condition
attribute for<*depend>
tags in package.xml format 3 (REP014)#1038 added support for the
condition
attribute to the<build_type>
tag, but it was never added to the other<*depend>
tags.Without this change:
In Noetic (py3), package.xml containing
yields CMake variable:
${PROJECT_NAME}_EXEC_DEPENDS = "python-whatever;python3-whatever"
After this change:
The same package.xml yields CMake variable:
${PROJECT_NAME}_EXEC_DEPENDS = "python3-whatever"
If approved, I would also like this to be considered for backport to kinetic & melodic.