Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add leading character to node name #109

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Re-add leading character to node name #109

merged 1 commit into from
Jun 3, 2020

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 16, 2019

The ROS 2 API is giving us the node name without a leading slash.

Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.
@ahendrix do you mind merging this?

@rotu
Copy link
Contributor

rotu commented Jul 23, 2019

Fixes #83 ?

@cottsay
Copy link
Member Author

cottsay commented Jul 24, 2019

#83 seems to suggest that it is possible for the leading slash to be present, which I have never observed. I'll have to mess around with this a little more to see if I can get it to show up, or explain what changed to make it disappear.

@Karsten1987 Karsten1987 added the ros2 PR tackling a ROS2 branch label Sep 18, 2019
The ROS 2 API is giving us the node name without a leading slash.
@Karsten1987 Karsten1987 merged commit ad8da88 into ros:ros2-devel Jun 3, 2020
@cottsay cottsay deleted the ros2_node_name branch June 3, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros2 PR tackling a ROS2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants