Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting required-ros-distributions #358

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Setting required-ros-distributions #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ab7d7c9
setting required-ros-distributions
ct2034 May 14, 2024
e05011d
jazzy on noble (24.04)
ct2034 May 14, 2024
1684995
Can we skip workarounds?
ct2034 May 14, 2024
bb511f6
note on pep257 failing
ct2034 May 14, 2024
0ebed95
removing pydocstyle fixes and setting distro properly
ct2034 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
pull_request:
push:
branches:
- ros2
- ros2-jazzy
schedule:
# Run every week at 20:00 on Sunday
- cron: "0 20 * * 0"
Expand All @@ -18,17 +18,23 @@ jobs:
cppcheck,
cpplint,
flake8,
pep257,
# pep257, TODO: enable when we fixed
# Error: diagnostic_common_diagnostics/diagnostic_common_diagnostics/ntp_monitor.py:113 in public method `ntp_diag`: D417: Missing argument descriptions in the docstring (argument(s) st are missing descriptions in 'ntp_diag' docstring)
# using ros-rolling-ament-pep257 amd64 0.18.0-1noble.20240426.150718
uncrustify,
xmllint,
]
runs-on: ubuntu-22.04
include:
- distro: jazzy
os: ubuntu-24.04
runs-on: ${{ matrix.os }}
env:
AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS: 1
steps:
- uses: actions/checkout@v1
- uses: ros-tooling/setup-ros@master
- run: sudo pip install pydocstyle==6.1.1 # downgrade to fix https://github.com/ament/ament_lint/pull/428
with:
required-ros-distributions: ${{ matrix.distro }}
- uses: ros-tooling/action-ros-lint@master
with:
linter: ${{ matrix.linter }}
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,12 @@ jobs:
]
include:
- distro: jazzy
os: ubuntu-22.04
os: ubuntu-24.04
runs-on: ${{ matrix.os }}
steps:
- uses: ros-tooling/setup-ros@master
- run: |
sudo pip install pydocstyle==6.1.1 # downgrade to fix https://github.com/ament/ament_lint/pull/428
sudo pip install pip --upgrade
sudo pip install pyopenssl --upgrade # fix for AttributeError: module 'lib' has no attribute 'X509_V_FLAG_CB_ISSUER_CHECK'
with:
required-ros-distributions: ${{ matrix.distro }}
- uses: ros-tooling/action-ros-ci@master
with:
target-ros2-distro: ${{ matrix.distro }}
Expand Down
Loading