Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2-humble] Add add_analyzer functionality (#329) #359

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

ct2034
Copy link
Collaborator

@ct2034 ct2034 commented Jun 27, 2024

Backport

This will backport the following commits from ros2 to ros2-humble:

Questions ?

Please refer to the Backport tool documentation

* Add add_analyzer functionality
* Add copyright notice and license, remove unused includes, re-order includes correctly
* Increase clarity of prefix_ by renaming it to analyzers_ns_
* Add add_analyzer functionality
* Fix bug where base_path is not reset correctly
* Make the parameter forwarding condition more generic, fix the default service namespace from diagnostics_agg to analyzers
* Add an add_analyzer example to the diagnostic_aggregator
* Update the relevant READMEs
* Fix linter errors
* Add test for add_analyzer at runtime, remove unnecessary ros info logger, remove unnecessary hardcoded namespace from yaml files
* Remove the now redundant analyzers_ns_
* Change the copyright of add_analyzer, forgot to update it to Nobleo after copying the notice

(cherry picked from commit 5e1415c)
@ct2034 ct2034 merged commit 5933c90 into ros:ros2-humble Jun 27, 2024
11 checks passed
@ct2034 ct2034 deleted the backport/ros2-humble/pr-329 branch June 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants