Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize header includes by moving impl to .cpp files (#331) and Fix usage of rclcpp::ok with a non-default context (#352) #390

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Minimize header includes by moving impl to .cpp files (#331) and Fix usage of rclcpp::ok with a non-default context (#352) #390

merged 2 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Minimize header includes by moving impl to .cpp files (#331) 

    * Minimize header includes by moving impl to .cpp files
* Make sure to build a shared library

Signed-off-by: Christian Henkel <[email protected]>
    @Rayman @ct2034
    Rayman authored and ct2034 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3ab8233 View commit details
    Browse the repository at this point in the history

  2. Fix usage of rclcpp::ok with a non-default context (#352) 

    * Fix usage of rclcpp::ok with a non-default context

The current implementation calls `rclcpp::ok` without any arguments,
which amounts to verifying that the global default context is valid. In
the case where a node is added to a custom context, and the global
context is not used, `rclcpp::ok` without any arguments will always
return `false` since the global context has never been initialized. To
fix it, pass to rclcpp the context that's available via the node's base
interface.

* Add a test for custom context

Signed-off-by: Christian Henkel <[email protected]>
    @haudren-woven @ct2034
    haudren-woven authored and ct2034 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    423e7f6 View commit details
    Browse the repository at this point in the history