Feature to show deprecation warning for msg/srv #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkentaro
added a commit
to wkentaro/gencpp
that referenced
this pull request
May 14, 2018
dirk-thomas
reviewed
May 29, 2018
cmake/genmsg-extras.cmake.em
Outdated
| list(APPEND ${PROJECT_NAME}_DEPRECATED_MESSAGE_FILES ${FILES_W_PATH}) | ||
| else() | ||
| list(APPEND ${PROJECT_NAME}_MESSAGE_FILES ${FILES_W_PATH}) | ||
| endif() |
There was a problem hiding this comment.
Using two different lists doesn't seem to be a good data structure for this. As a consequence you have to change code which shouldn't need to be touched.
Instead I would suggest to keep ${PROJECT_NAME}_MESSAGE_FILES as it is and have a second map which additionally stores the ones which are deprecated.
|
Looks great, I dig it! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #67
Why?
I needed to remove or migrate some messages/services from packages, and I'd like to show deprecation warning for users. This PR enables that feature.
Usage
gencpp example: ros/gencpp#35