added support for buffer / memoryview data #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 28, 2019
src/genpy/generator.py
Outdated
| yield INDENT+"tmp = memoryview(%s) if python3 else buffer(%s)"%(var,var) | ||
| yield INDENT+pack2("'<I'", "tmp.nbytes if python3 else len(tmp)") | ||
| yield INDENT+serializeit("tmp") | ||
| yield "except:" |
There was a problem hiding this comment.
This shouldn't catch arbitrary exception but only specific types which are expected to be thrown. Also the scope of the try / except block should be as short as possible.
|
@tzickel Friendly ping. |
|
A continuation of this PR is in #147 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before testing, I rather get feedback if this is a sane / valid solution... (i.e. first trying with an exception handler), also it might fail on non trivial layouts (not sure if fail exception as would before, or fail by sending wrong data?).
Trying to fix #107