{common}: add license map to fix BSD license issue #1256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since BSD file was removed in YOCTO/scarthgap, some ROS recipes build failed due to cannot find BSD license. Map BSD to BSD-3-Clause similar to YOCTO/kirkstone. Signed-off-by: Jiaxing Shi <[email protected]>
jiaxshi
force-pushed
the
scarthgap-license
branch
from
a299c5b to
2befecf
Compare
|
I know the right way is to ask the maintainer of each projects to add explicitly license context. Before that, how can we use meta-ros? |
|
FWIW: I believe this is wrong and I've replied before with links to superflore where it was discussed how to fix this properly. But I no longer maintain or use meta-ros, so I don't really mind, just my 2c. |
|
I don't feel comfortable using the SPDXLICENSEMAP for BSD, just because I have caught examples in ROS named "BSD" that were not BSD-3-Clause. Thanks for trying to help though. It is an annoying problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BSD file was removed in YOCTO/scarthgap, some ROS recipes build failed due to cannot find BSD license.
Map BSD to BSD-3-Clause similar to YOCTO/kirkstone.
Fix issue #1208
@robwoolley Could you please review and check if this change is fine to merge?