Add a plugin mechanism to resource_retriever #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Aug 17, 2024
ahcorde
requested changes
Aug 19, 2024
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/filesystem_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/filesystem_retriever.hpp
Outdated
Show resolved
Hide resolved
resource_retriever/include/resource_retriever/plugins/curl_retriever.hpp
Show resolved
Hide resolved
Yadunund
reviewed
Aug 21, 2024
resource_retriever/include/resource_retriever/memory_resource.hpp
Outdated
Show resolved
Hide resolved
clalancette
requested changes
Dec 3, 2024
wjwwood
force-pushed
the
mjcarroll/plugins
branch
from
4ffb1bc to
8a30432
Compare
|
I fixed up the DCO and addressed review comments in 8a30432, @clalancette could you have another quick look? |
Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: William Woodall <[email protected]>
Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: William Woodall <[email protected]>
Signed-off-by: Voldivh <[email protected]> Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: William Woodall <[email protected]>
Signed-off-by: William Woodall <[email protected]>
wjwwood
force-pushed
the
mjcarroll/plugins
branch
from
8a30432 to
8e0fae7
Compare
Signed-off-by: William Woodall <[email protected]>
clalancette
requested changes
Dec 18, 2024
| @@ -33,30 +33,18 @@ | |||
| #include <memory> | |||
| #include <stdexcept> | |||
There was a problem hiding this comment.
Suggested change
| #include <stdexcept> |
| /** | ||
| * \brief Get a file and store it in memory | ||
| * \param url The url to retrieve. package://package/file will be turned into the correct file:// invocation | ||
| * \return The file, loaded into memory | ||
| * \throws resource_retriever::Exception if anything goes wrong. | ||
| */ | ||
| MemoryResource get(const std::string & url); | ||
| MemoryResourcePtr get(const std::string & url); |
There was a problem hiding this comment.
This is an important change to the API, going from returning a structure to returning a shared_ptr. Given that we usually tick-tock this stuff, can we add back the old API and mark it as deprecated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this is to make
resource_retrieverpluggable. That is that downstream users of the library can choose the mechanisms that they want to back the calls to "get".This will allow for things like retrieving over ROS services or parameters.