Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding static transform listener #673

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

ayrton04
Copy link
Contributor

@ayrton04 ayrton04 commented Apr 26, 2024

Addressses #662.

I went with @clalancette's suggestion and just added a static_only parameter (with a default of false) to the constructors and the init method.

However, that made things slightly awkward, for two reasons:

  1. In order to specify static_only, we have to now specify a ton of other optional parameters.
  2. If we are setting static_only to true, we now have to specify parameters for the behaviour of the dynamic transform subscriber, even though it won't be used. That felt clunky.

So in addition to the above, I also created a "convenience" class, StaticTransformListener. It inherits from TransformListener and has equivalent constructors (but without the dynamic subscriber parameters). It simply calls the base TransformListener constructor with the required parameters, using dummy values for the dynamic transform subscriber options and QoS.

In addition, I added tests:

  1. I added tests that were exactly equivalent to the TransformListener tests, which seem largely aimed at just constructing listeners, rather than using them.
  2. I added a new test that has a TransformListener and a StaticTransformListener. We publish dynamic and static transforms, and then check to see if the respective dynamic and static buffers have the transforms we expect.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Apr 26, 2024

@clalancette any comments on this one ?

@sloretz
Copy link
Contributor

sloretz commented May 10, 2024

@clalancette friendly ping 🧇

@ahcorde
Copy link
Contributor

ahcorde commented May 15, 2024

@clalancette do you mind to take a look ?

@ahcorde
Copy link
Contributor

ahcorde commented Jun 11, 2024

friendly ping @clalancette

@ayrton04
Copy link
Contributor Author

Hello! Not wanting to be difficult at all, but as we're approaching the 3-month mark for this PR, it would be really great if we could either approve it or reject it. If we're not happy with the overall implementation, I am happy to change it (or just close the PR, if we feel this changes too much).

Thanks!

@ahcorde
Copy link
Contributor

ahcorde commented Aug 21, 2024

friendly ping @clalancette

@ahcorde
Copy link
Contributor

ahcorde commented Aug 27, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit d851022 into ros2:rolling Aug 28, 2024
2 checks passed
@ayrton04 ayrton04 deleted the 662-static-transform-listener branch August 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants