-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding static transform listener #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette any comments on this one ? |
@clalancette friendly ping 🧇 |
@clalancette do you mind to take a look ? |
friendly ping @clalancette |
Hello! Not wanting to be difficult at all, but as we're approaching the 3-month mark for this PR, it would be really great if we could either approve it or reject it. If we're not happy with the overall implementation, I am happy to change it (or just close the PR, if we feel this changes too much). Thanks! |
friendly ping @clalancette |
Addressses #662.
I went with @clalancette's suggestion and just added a
static_only
parameter (with a default offalse
) to the constructors and theinit
method.However, that made things slightly awkward, for two reasons:
static_only
, we have to now specify a ton of other optional parameters.static_only
totrue
, we now have to specify parameters for the behaviour of the dynamic transform subscriber, even though it won't be used. That felt clunky.So in addition to the above, I also created a "convenience" class,
StaticTransformListener
. It inherits fromTransformListener
and has equivalent constructors (but without the dynamic subscriber parameters). It simply calls the baseTransformListener
constructor with the required parameters, using dummy values for the dynamic transform subscriber options and QoS.In addition, I added tests:
TransformListener
tests, which seem largely aimed at just constructing listeners, rather than using them.TransformListener
and aStaticTransformListener
. We publish dynamic and static transforms, and then check to see if the respective dynamic and static buffers have the transforms we expect.