Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ModuleNotFoundError in entry point discovery #758

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Ignore ModuleNotFoundError in entry point discovery #758

wants to merge 1 commit into from

Conversation

mathias-luedtke
Copy link

@mathias-luedtke mathias-luedtke commented Feb 5, 2024 •
edited
Loading

This prevents pytest (or colcon test) from failing if a module imports a (deliberately) missing dependency.

@audrow
Copy link
Member

audrow commented Feb 15, 2024

Hi @mathias-luedtke, could you give us a motivating example and add a test for this?

@audrow audrow added the more-information-needed Further information is required label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
more-information-needed Further information is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathias-luedtke @audrow