Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows substitutions with Python Standard Path Objects with PathSubstitutions #790

Open
wants to merge 9 commits into
base: rolling
Choose a base branch
from

Conversation

InvincibleRMC
Copy link

Creates PathSubstitutions and update some types. For more information on Path check out the documentation here

Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC InvincibleRMC marked this pull request as ready for review July 18, 2024 23:47
Signed-off-by: Michael Carlstrom <[email protected]>
@mjcarroll mjcarroll self-assigned this Aug 8, 2024
@mjcarroll
Copy link
Member

This is a great addition, thanks. I'm going to run this through CI. In the meantime, can you add to the Substitution documentation: https://github.com/ros2/launch/blob/rolling/launch/doc/source/architecture.rst?plain=1#L114

Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Copy link
Author

@mjcarroll Just following up, do you need anything else from me?

Signed-off-by: Michael Carlstrom <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants