-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute process refactor #215
base: rolling
Are you sure you want to change the base?
Changes from 1 commit
6689fe0
e5ef999
83c4529
87948a8
2f4937d
b38ea73
4be19e5
9ad74b5
f1ae020
5f4ac9f
1bb350e
29788c4
43f1912
b9531dd
d5b83d5
4b45bc5
846295c
32409af
6e95e60
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
Distro A; OPSEC #4584 Signed-off-by: Roger Strain <[email protected]>
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,7 +88,8 @@ def test_launch_node_with_remappings(self): | |
self._assert_launch_no_errors([node_action]) | ||
|
||
# Check the expanded parameters. | ||
expanded_remappings = node_action._Node__node_desc.expanded_remappings | ||
for node in node_action.ros_exec.nodes: | ||
expanded_remappings = node.expanded_remappings | ||
assert len(expanded_remappings) == 2 | ||
for i in range(2): | ||
assert expanded_remappings[i] == ('chatter', 'new_chatter') | ||
|
@@ -147,7 +148,8 @@ def test_launch_node_with_parameter_files(self): | |
self._assert_launch_no_errors([node_action]) | ||
|
||
# Check the expanded parameters. | ||
expanded_parameter_arguments = node_action._Node__node_desc.expanded_parameter_arguments | ||
for node in node_action.ros_exec.nodes: | ||
expanded_parameter_arguments = node.expanded_parameter_arguments | ||
assert len(expanded_parameter_arguments) == 3 | ||
for i in range(3): | ||
assert expanded_parameter_arguments[i] == (str(parameters_file_path), True) | ||
|
@@ -184,7 +186,8 @@ def test_launch_node_with_parameter_descriptions(self): | |
) | ||
self._assert_launch_no_errors([node_action]) | ||
|
||
expanded_parameter_arguments = node_action._Node__node_desc.expanded_parameter_arguments | ||
for node in node_action.ros_exec.nodes: | ||
expanded_parameter_arguments = node.expanded_parameter_arguments | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mlanting hmm, should these be extending the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that would probably be more appropriate. I'll make the change. |
||
assert len(expanded_parameter_arguments) == 5 | ||
parameters = [] | ||
for item, is_file in expanded_parameter_arguments: | ||
|
@@ -221,7 +224,8 @@ def test_launch_node_with_parameter_dict(self): | |
self._assert_launch_no_errors([node_action]) | ||
|
||
# Check the expanded parameters (will be written to a file). | ||
expanded_parameter_arguments = node_action._Node__node_desc.expanded_parameter_arguments | ||
for node in node_action.ros_exec.nodes: | ||
expanded_parameter_arguments = node.expanded_parameter_arguments | ||
assert len(expanded_parameter_arguments) == 1 | ||
file_path, is_file = expanded_parameter_arguments[0] | ||
assert is_file | ||
|
@@ -356,5 +360,6 @@ def get_test_node_name_parameters(): | |
) | ||
def test_node_name(node_object, expected_result): | ||
lc = LaunchContext() | ||
node_object._Node__node_desc._perform_substitutions(lc, []) | ||
for node in node_object.ros_exec.nodes: | ||
node._perform_substitutions(lc, []) | ||
assert node_object.is_node_name_fully_specified() is expected_result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roger-strain missing
pass
after docstring?