Update for remapping order of __ns and __node to not affect each other #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <[email protected]>
ivanpauno
requested changes
Oct 19, 2020
There was a problem hiding this comment.
This is blocked until the changes proposed in ros2/design#299 are approved.
I will bring up the proposal in next team meeting, to hear what other people think about the change.
(I'm only clicking request-changes so this is not merged until the design PR is approved)
ivanpauno
added
enhancement
|
Closing, see ros2/design#299 (comment) for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #806
Signed-off-by: Chen Lihui [email protected]