Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for rest of obvious boolean extra arguments and throw for unsupported ones #2685

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

rcp1
Copy link
Contributor

@rcp1 rcp1 commented Nov 22, 2024

Improves situation for #978.

Instead of arbitrarily only allowing forward_global_arguments and use_intra_process_comms as extra arguments for loading a component, this PR enables support for all obvious boolean node options.

#978 discusses more problematic options like allow_undeclared_parameters, which are still unsupported.

At least, this PR adds an error message if such or other unsupported extra arguments are passed.

@mjcarroll
Copy link
Member

Pulls: #2685
Gist: https://gist.githubusercontent.com/mjcarroll/4cf1ea0d0bfd14e07de243e49cbf7504/raw/35d3b41794eef76f498efb6802804c62de94cd4f/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp_components
TEST args: --packages-above rclcpp_components
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14951

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit aad8cb5 into ros2:rolling Dec 13, 2024
3 checks passed
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not well-described in ros2 documentation, it is really hard to know for user what extra arguments are available. I can follow this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants