-
Notifications
You must be signed in to change notification settings - Fork 235
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
104baeb
commit 095267c
Showing
1 changed file
with
6 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
095267c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That leaves us with the question why the CI builds passed before??
095267c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depend which change you;re referring to:
I dont think there is anything in CI exercising
service_names_and_types
.For the qos profile, I think it just have been ignored (because if the capsule is invalid we use the default qos profile). Given that we dont test qos settings in test_communication yet, no test would have caught it
095267c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test to make sure
node.service_names_and_types()
doesn't raise in 76f4359. It fails without the changes in this commit.095267c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, is it possible to add one for
topic_names_and_types
as well ?095267c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I threw in
get_node_names
too d4048f6