Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action Client #262

Merged
merged 36 commits into from
Feb 5, 2019
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b68d281
Add rclpy_action module
jacobperron Jan 15, 2019
2270989
[WIP] Implement action client
jacobperron Jan 18, 2019
33676c9
Add tests using mock action server
jacobperron Jan 23, 2019
eba5452
Add more of the Action extension module
jacobperron Jan 23, 2019
b217726
Implement send goal for action client
jacobperron Jan 23, 2019
c3df614
Remove action client as a waitable when destroyed
jacobperron Jan 23, 2019
4aa2480
Rename shared header file
jacobperron Jan 23, 2019
8336024
Add ClientGoalHandle class and implement action client feedback
jacobperron Jan 23, 2019
c75f66e
Implement cancel_goal_async
jacobperron Jan 24, 2019
6d5d3bb
Implement get_result_async
jacobperron Jan 24, 2019
fb294d6
Update ClientGoalHandle status from status array message
jacobperron Jan 24, 2019
85758ab
Lint
jacobperron Jan 24, 2019
21f852a
Minor refactor
jacobperron Jan 24, 2019
1ba2a3f
Fix action client test
jacobperron Jan 24, 2019
9c53704
Implement synchronous action client methods
jacobperron Jan 24, 2019
7ce5e74
Address review
jacobperron Jan 25, 2019
b661737
Add action module for aggregating action related submodules
jacobperron Jan 25, 2019
f2b238c
Only destroy action client if node has not been destroyed
jacobperron Jan 26, 2019
9870847
Improve error handling and add missing DECREF in rclpy_convert_to_py_…
jacobperron Jan 26, 2019
d3d8274
Only check waitables for ready entities for wait sets they were added to
jacobperron Jan 28, 2019
34db026
Address review
jacobperron Jan 28, 2019
e405bd9
Extend Waitable API so executors are aware of Futures
jacobperron Jan 28, 2019
eced951
Minor refactor
jacobperron Jan 29, 2019
37ac761
Process feedback and status subscriptions after services
jacobperron Jan 30, 2019
69a2c47
Fix lint
jacobperron Jan 30, 2019
7cfb217
Move Action source files into 'action' directory
jacobperron Feb 1, 2019
4505849
Move check_for_type_support() to its own module
jacobperron Feb 1, 2019
04337c9
Minor refactor of ActionClient
jacobperron Feb 1, 2019
ab8c6ae
Add test for sending multiple goals with an ActionClient
jacobperron Feb 1, 2019
52afeca
Fix DECREF calls
jacobperron Feb 1, 2019
12907d7
Refactor ClientGoalHandle
jacobperron Feb 1, 2019
102de88
action_server -> action_client
jacobperron Feb 1, 2019
e2df735
Maintain weak references to GoalHandles in ActionClient
jacobperron Feb 2, 2019
b6c6ca8
Double test timeout
jacobperron Feb 4, 2019
cc2b886
Revert "Double test timeout"
jacobperron Feb 4, 2019
c1422be
Disable failing test
jacobperron Feb 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions rclpy/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ endif()
find_package(ament_cmake REQUIRED)
find_package(ament_cmake_python REQUIRED)
find_package(rcl REQUIRED)
find_package(rcl_action REQUIRED)
find_package(rcl_yaml_param_parser REQUIRED)
find_package(rcutils REQUIRED)
find_package(rmw REQUIRED)
Expand Down Expand Up @@ -82,6 +83,17 @@ ament_target_dependencies(rclpy
"rcutils"
)

add_library(
rclpy_action
SHARED src/rclpy/_rclpy_action.c
)
configure_python_c_extension_library(rclpy_action)
ament_target_dependencies(rclpy_action
"rcl"
"rcl_action"
"rcutils"
)

# Logging support provided by rcutils
add_library(
rclpy_logging
Expand Down
2 changes: 2 additions & 0 deletions rclpy/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@

<depend>rmw_implementation</depend>
<depend>rcl</depend>
<depend>rcl_action</depend>
<depend>rcl_yaml_param_parser</depend>
<depend>unique_identifier_msgs</depend>

<exec_depend>ament_index_python</exec_depend>
<exec_depend>builtin_interfaces</exec_depend>
Expand Down
15 changes: 15 additions & 0 deletions rclpy/rclpy/action.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Copyright 2019 Open Source Robotics Foundation, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from rclpy.action_client import ActionClient # noqa
jacobperron marked this conversation as resolved.
Show resolved Hide resolved
Loading