Fix topic name mangling when not using ros conventions #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
changed the title
ivanpauno
changed the title
sloretz
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Skipping the prefix matches rmw_fastrtps and rmw_connext. I haven't figured out what the suffix is for, though Connext doesn't have an option for a suffix so it probably doesn't matter.
The suffix is added to services |
…aming-conventions
|
CI ok in ros2/system_tests#428 (comment) ; merging ahead of nightlies |
delete-merged-branch
bot
deleted the
ivanpauno/fix-problem-when-not-using-ros-naming-conventions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/system_tests#428.