Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change order in node initialization #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change order in node initialization #339

wants to merge 1 commit into from
+4 −4

Conversation

sgermanserrano
Copy link

@sgermanserrano sgermanserrano commented Dec 13, 2021 •
edited
Loading

Follows comment in #316

Signed-off-by: Servando German Serrano [email protected]

@sgermanserrano
change order in node initialization
70d0d73 
Signed-off-by: Servando German Serrano <[email protected]>
fujitatomoya
fujitatomoya reviewed Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments.

  • Is this modification only required to parameter_bridge? probably we need to apply this fix to other places such as simple_bridge?
  • it would be nice to add test to make sure.

fujitatomoya
fujitatomoya reviewed Dec 13, 2021
View reviewed changes
src/parameter_bridge.cpp
// ROS 2 node
rclcpp::init(argc, argv);
auto ros2_node = rclcpp::Node::make_shared("ros_bridge");

// ROS 1 node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we would want to add comments why this rclcpp::init needs to be called before ros::init.

@fujitatomoya
Copy link
Collaborator

CC: @iuhilnehc-ynos

@msmcconnell msmcconnell mentioned this pull request Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgermanserrano @fujitatomoya