Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined branch #1

Merged
merged 48 commits into from
Mar 3, 2022
Merged

Combined branch #1

merged 48 commits into from
Mar 3, 2022

Conversation

msmcconnell
Copy link

This PR updates the develop branch of our fork to include the following PRs
ros2#331
ros2#315
ros2#339

jacobperron and others added 30 commits October 9, 2020 18:25
Signed-off-by: Jacob Perron <[email protected]>
… rosidl_adapter and .msg files (ros2#296)

* update to use rosidl_parser and .idl files rather than rosidl_adapter and .msg files

Signed-off-by: William Woodall <[email protected]>

* fix quote style linting error

Signed-off-by: William Woodall <[email protected]>
* very minor typo in comments

* Fix other copy-paste typos.

Co-authored-by: Steven! Ragnarök <[email protected]>
Co-authored-by: tomoya <[email protected]>
* Fix logging for updated rclcpp interface

Signed-off-by: Michael Carroll <[email protected]>

* Update src/bridge.cpp

Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Ivan Santiago Paunovic <[email protected]>

* Update to pass char *

Signed-off-by: Michael Carroll <[email protected]>

* Uncrustify

Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
* init docker based CI

Signed-off-by: Harsh Deshpande <[email protected]>

* target rolling only

Signed-off-by: Harsh Deshpande <[email protected]>

* use setup-ros and action-ros-ci instead of custom scripts

Signed-off-by: Harsh Deshpande <[email protected]>

* quiet blind except warnings

ros2#310 (comment)

Signed-off-by: Harsh Deshpande <[email protected]>

* remove ccache

build times are not a concern and it is not significantly improved when using ros-tooling actions

Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
and resotre the original main loop logic

Signed-off-by: Chen Lihui <[email protected]>
to fix 'Not all nodes were finished before finishing the context'
since ros2 PublisherBase passed into ros1 subscriber as parameter
which might be freed after ros2 context.

Signed-off-by: Chen Lihui <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Chen Lihui <[email protected]>
See if that fixes the apt-update part of CI

Signed-off-by: Shane Loretz <[email protected]>
* Add example for using the parameter_bridge

Signed-off-by: Loy van Beek <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Loy van Beek <[email protected]>
LoyVanBeek and others added 18 commits October 18, 2021 15:02
Signed-off-by: Loy van Beek <[email protected]>
Signed-off-by: Loy van Beek <[email protected]>
…representation of liveliness enum values

Signed-off-by: Loy van Beek <[email protected]>
In 2 cases the formatting conflicts with what uncrustify wants; // NOLINT got rid of the complaints of cpplint, favouring uncrustify

Signed-off-by: Loy van Beek <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Loy van Beek <[email protected]>
* Update package maintainers

Signed-off-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Servando German Serrano <[email protected]>
@msmcconnell msmcconnell merged commit 3f62f19 into develop Mar 3, 2022
@msmcconnell msmcconnell deleted the combined_branch branch March 3, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.