Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM Filter Refactor #194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

RPM Filter Refactor #194

wants to merge 4 commits into from

Conversation

rotorflight
Copy link
Owner

@rotorflight rotorflight commented Nov 27, 2024

This is a draft for the new RPM filter with presets.

LATEST UPDATE: 31/12/2024

NOTE! The MSP interface is not compatible with the Configurator, until it is fixed.

@rotorflight
Copy link
Owner Author

rotorflight commented Nov 27, 2024

At the moment, the new parameters are available via CLI only.

Global settings

set gyro_rpm_notch_preset = <0...3>

Preset 0: Custom settings
Preset 1: Low vibes
Preset 2: Average vibes
Preset 3: Strong vibes

set gyro_rpm_notch_min_hz = <Hz>

Minimum frequency allowed with notches. Default 20Hz. Probably ok for most people.

Custom preset settings

set gyro_rpm_notch_source_pitch = <array [16]>

Select notch frequency source for pitch axis.

set gyro_rpm_notch_center_pitch = <array [16]>

Center frequency adjustment. 0 = no adjustment, 500 = +5%, -500 = -5%, etc.

set gyro_rpm_notch_q_pitch = <array [16]>

Set the Q value (x10) for the notches.

RPM Source indexing

10    Main motor (if geared)
11    Main rotor fundamental
12    Main rotor 2. harmonic
13    Main rotor 3. harmonic
14    Main rotor 4. harmonic
15    Main rotor 5. harmonic
16    Main rotor 6. harmonic
17    Main rotor 7. harmonic
18    Main rotor 8. harmonic
...
20    Tail motor (if geared)
21    Tail rotor fundamental
22    Tail rotor 2. harmonic
23    Tail rotor 3. harmonic
24    Tail rotor 4. harmonic
...

See settings

get gyro_rpm

NOTE!

If any of the presets is selected, the custom values are automatically reset to the preset values!
Thus, the BB header will always show the actual values used.

@rotorflight rotorflight force-pushed the rpm_filter_refactor branch 2 times, most recently from 6a475f1 to 670157c Compare December 19, 2024 11:44
@rotorflight rotorflight mentioned this pull request Dec 19, 2024
@rotorflight rotorflight force-pushed the rpm_filter_refactor branch 3 times, most recently from 8441a47 to 43b2baa Compare December 31, 2024 10:52
The RPM filter changes breaks inter-version compatibility in MSP,
required between minor versions.
@rotorflight rotorflight changed the title DRAFT: RPM Filter Refactor RPM Filter Refactor Jan 1, 2025
@rotorflight rotorflight marked this pull request as ready for review January 1, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants