daemon: D-Bus API to cancel current transaction #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hard coded constants use enum as callbacks return values.
m-blaha
force-pushed
the
mblaha/daemon-cancel-download
branch
from
41f5a93
to
274f7cb
Compare
New API `Goal.cancel()` cancels the transaction that was initiated by `do_transaction()`. The transaction can only be canceled during the package download phase. Once the RPM transaction has begun, cancellation is no longer permitted.
m-blaha
force-pushed
the
mblaha/daemon-cancel-download
branch
from
274f7cb
to
aec787f
Compare
jan-kolarik
approved these changes
Sep 4, 2024
mcrha
reviewed
Sep 5, 2024
| --> | ||
| <method name="cancel"> | ||
| <arg name="success" type="b" /> | ||
| <arg name="error_msg" type="s" /> |
There was a problem hiding this comment.
Set direction="out" for both of these, please. The default, when not set, is the arguments are input arguments.
There was a problem hiding this comment.
I opened #1679 for this (the change is part of it)
mcrha
added a commit
to mcrha/dnf5
that referenced
this pull request
Sep 6, 2024
…::cancel method Both the arguments are output arguments, to be read by client, not to be set by the client, thus mark them as such. Related to rpm-software-management#1665 (comment)
mcrha
added a commit
to mcrha/dnf5
that referenced
this pull request
Sep 6, 2024
…::cancel method Both the arguments are output arguments, to be read by client, not to be set by the client, thus mark them as such. Related to rpm-software-management#1665 (comment)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…::cancel method Both the arguments are output arguments, to be read by client, not to be set by the client, thus mark them as such. Related to #1665 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1660
Changes:
41f5a93 (Marek Blaha, 38 minutes ago)
dnfdaemon: API to cancel running Goal.do_transaction()
During the download phase, calling Goal.cancel() will cause all downloads
to abort and transaction will not be performed. Once the rpm transaction is
started, the cancel is not any more allowed and rpm transaction will
finish.
b8e03b2 (Marek Blaha, 39 minutes ago)
DownloadCallbacks: Enum for possible return codes
Instead of hard coded constants use enum as callbacks return values.