Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N: Mark messages in "dnf install" output for a translation #1696

Merged
merged 1 commit into from
Sep 16, 2024

Commits on Sep 13, 2024

  1. I18N: Mark messages in "dnf install" output for a translation

    Many texts were always in English because the code did not
    internatialinze them. This patch fixes it.
    
    fmt::format() calls were replaced with libdnf5::utils::sformat()
    calls to be able to pass a localized string as a formatting string.
    
    Sentences glued from words, e.g. "Installing dependencies:" in
    a transaction table, were changed to a single-string sentences in the
    code. Having a full sentece is important for the translators.
    
    I fixed spelling at few places, especially around importing PGP keys.
    
    I used internatinoalized plural forms in the transaction summary
    ("Installing: 1 package" vs "Installing: 2 packages").
    
    I also internationalized output to DNF log. At the end, it's
    a human-oriented text.
    
    I intentionally left out libdnf_throw_assertion() arguments from the
    internationalization because that function needs changing its
    implmentation to accept nonconst-literal formatting string. That will
    be implemented in a separate patch.
    
    I manully tested significant parts of the output to be sure the
    messages propetly undergo localization.
    
    Resolves: rpm-software-management#1688
    ppisar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    42dbc60 View commit details
    Browse the repository at this point in the history