Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ManagedBatchParser version to 5.0.20250220.4 #718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 2, 2025

Automated changes by Update ManagedBatchParser action

Copy link
Collaborator

@jeffrosenberg jeffrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but see my comments, it looks like last week's update used a pre-release version. My best guess is that this isn't an issue with our automation, but I'll be double-checking these PRs for a few weeks.

@@ -1 +1 @@
5.0.20250221.1
5.0.20250220.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this change makes me wonder if the automation made some kind of mistake. The version actually appears to be a day older than the previous. When I look at the sqltoolsservice releases, it appears 5.0.20250221.1 is marked as "pre-release", and 5.0.20250220.4 is marked as "latest".
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd note that when I curl the /releases/latest endpoint (https://api.github.com/repos/microsoft/sqltoolsservice/releases/latest), 5.0.20250220.4 is what gets returned. So I think this change is correct, but I'm not sure what happened last week. If I had to guess, I'd guess that 5.0.20250221.1 wasn't properly marked as pre-release. But I'm going to keep an eye on this for the next few weeks and see if any adjustments are needed.

@github-actions github-actions bot force-pushed the actions/managed-batch-parser-5.0.20250220.4 branch from efcc18f to feb4ef4 Compare March 9, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants