Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ManagedBatchParser version to 5.0.20250220.4 #718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ManagedBatchParser version to 5.0.20250220.4 #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...acpacTool/Microsoft.SqlTools.ManagedBatchParser/Microsoft.SqlTools.ManagedBatchParser.dll
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/DacpacTool/Microsoft.SqlTools.ManagedBatchParser/version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.0.20250221.1
5.0.20250220.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this change makes me wonder if the automation made some kind of mistake. The version actually appears to be a day older than the previous. When I look at the sqltoolsservice releases, it appears 5.0.20250221.1 is marked as "pre-release", and 5.0.20250220.4 is marked as "latest".
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd note that when I curl the /releases/latest endpoint (https://api.github.com/repos/microsoft/sqltoolsservice/releases/latest), 5.0.20250220.4 is what gets returned. So I think this change is correct, but I'm not sure what happened last week. If I had to guess, I'd guess that 5.0.20250221.1 wasn't properly marked as pre-release. But I'm going to keep an eye on this for the next few weeks and see if any adjustments are needed.